Fix getYearMonthText incorrect months #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Months was essentially calculated off a 48 week year, or each month being exactly 4 weeks, which isn't correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Months was essentially calculated off a 48 week year, or each month being exactly 4 weeks, which leads to the wrong output for airplane and fleet ages.
Under the old function:
51 weeks = 0 months
52 weeks = 1 year 1 months
479 weeks = 9 years 11 months
480 weeks = 9 years 0 months
With this fix:
51 weeks = 11 months
52 weeks = 1 year and 0 months
479 weeks = 9 years 2 months
480 weeks = 9 years 2 months